Be case-sensitive about responding to “RFC” #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I expect “rfc\d+” to be entirely false positives. This is probably most notable in the MIME type “message/rfc822” which crops up fairly often in the email space. If this approach of requiring capital “RFC” is considered too radical, an alternative would be to specifically not respond to “rfc822” (case sensitive). But that’s more work to implement.
|
I think it'd be better to say "(^|\s)rfc" or something and keep it case insensitive. |
|
I’m going to leave any finer decisions to others. |
rjbs
force-pushed
the
master
branch
4 times, most recently
from
ee8f9b7 to
2399855
Compare
rjbs
force-pushed
the
master
branch
5 times, most recently
from
25bf9c4 to
68c3b79
Compare
rjbs
force-pushed
the
master
branch
18 times, most recently
from
b9a2990 to
f00d771
Compare
rjbs
force-pushed
the
main
branch
2 times, most recently
from
b140047 to
945aca5
Compare
rjbs
force-pushed
the
main
branch
6 times, most recently
from
15d3cd9 to
3a95bf4
Compare
rjbs
force-pushed
the
main
branch
4 times, most recently
from
f23a1b1 to
4022b0d
Compare
rjbs
force-pushed
the
main
branch
9 times, most recently
from
32f29ba to
39ade23
Compare
rjbs
force-pushed
the
main
branch
4 times, most recently
from
aafd26b to
eee1d40
Compare
rjbs
force-pushed
the
main
branch
2 times, most recently
from
30b72ca to
03519d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect “rfc\d+” to be entirely false positives.
This is probably most notable in the MIME type “message/rfc822” which
crops up fairly often in the email space. If this approach of requiring
capital “RFC” is considered too radical, an alternative would be to
specifically not respond to “rfc822” (case sensitive). But that’s more
work to implement.